refactor(react-ui): ArrowCardPair#306
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
OmarBasem
force-pushed
the
omar/arrow-refactor
branch
from
July 8, 2026 15:56
ceaebce to
b1eb036
Compare
OmarBasem
force-pushed
the
omar/loading-view
branch
from
July 8, 2026 15:56
2b998ad to
17fe516
Compare
OmarBasem
force-pushed
the
omar/arrow-refactor
branch
from
July 9, 2026 07:45
b1eb036 to
9797ef9
Compare
OmarBasem
force-pushed
the
omar/loading-view
branch
from
July 9, 2026 07:45
17fe516 to
3f99258
Compare
OmarBasem
force-pushed
the
omar/loading-view
branch
from
July 9, 2026 11:17
3f99258 to
5d27feb
Compare
OmarBasem
force-pushed
the
omar/arrow-refactor
branch
from
July 9, 2026 11:17
9797ef9 to
75ae960
Compare
OmarBasem
force-pushed
the
omar/loading-view
branch
from
July 9, 2026 11:27
5d27feb to
f8f3c65
Compare
OmarBasem
force-pushed
the
omar/arrow-refactor
branch
from
July 9, 2026 11:27
75ae960 to
c2518df
Compare
OmarBasem
force-pushed
the
omar/loading-view
branch
from
July 9, 2026 11:41
f8f3c65 to
79cae8a
Compare
OmarBasem
force-pushed
the
omar/arrow-refactor
branch
from
July 9, 2026 11:41
c2518df to
4922e72
Compare
OmarBasem
force-pushed
the
omar/loading-view
branch
from
July 10, 2026 05:26
79cae8a to
8e2d956
Compare
OmarBasem
force-pushed
the
omar/arrow-refactor
branch
from
July 10, 2026 05:26
4922e72 to
25c55d9
Compare
OmarBasem
force-pushed
the
omar/arrow-refactor
branch
from
July 10, 2026 05:34
25c55d9 to
947f8c9
Compare
OmarBasem
force-pushed
the
omar/loading-view
branch
2 times, most recently
from
July 10, 2026 05:34
3cd4bdd to
edf9eae
Compare
OmarBasem
force-pushed
the
omar/arrow-refactor
branch
2 times, most recently
from
July 10, 2026 05:35
089de44 to
3760f17
Compare
brtkx
reviewed
Jul 14, 2026
Collaborator
There was a problem hiding this comment.
I never really liked the ArrowCardPair name, feels very verbose. How about ArrowStack or CardPair?
Member
Author
There was a problem hiding this comment.
Honestly I prefer ArrowCardPair over the other 2, but I can consider renaming it to something else. I was thinking maybe CardPairWithArrow although that's even longer, but more understandable I think.
Anyways I would prefer to rename it in a separate PR as that component touches several files that would cause many conflicts.
Collaborator
There was a problem hiding this comment.
Let's leave it as is then, it's more of a nit.
Collaborator
There was a problem hiding this comment.
react-ui needs changeset update since now we have automatic releases. It will be a patch change. wallet-react-ui doesn't need it because nothing changes on the consumer end.
Here's the full reference on how to do it. One note: we don't need to merge #316 - we can just keep on developing until we have a decent stack of changes or need an urgent release.
OmarBasem
force-pushed
the
omar/loading-view
branch
from
July 14, 2026 12:27
b670bbf to
955239a
Compare
OmarBasem
force-pushed
the
omar/arrow-refactor
branch
from
July 14, 2026 12:27
3760f17 to
23df8a7
Compare
OmarBasem
force-pushed
the
omar/loading-view
branch
from
July 14, 2026 12:37
955239a to
33fb6e2
Compare
OmarBasem
force-pushed
the
omar/arrow-refactor
branch
from
July 14, 2026 12:37
23df8a7 to
293b030
Compare
OmarBasem
force-pushed
the
omar/arrow-refactor
branch
from
July 14, 2026 13:11
293b030 to
48886df
Compare
OmarBasem
force-pushed
the
omar/loading-view
branch
from
July 14, 2026 13:11
33fb6e2 to
32f8ea2
Compare
OmarBasem
force-pushed
the
omar/arrow-refactor
branch
from
July 15, 2026 05:36
48886df to
e9b4caa
Compare
OmarBasem
force-pushed
the
omar/loading-view
branch
from
July 15, 2026 05:36
32f8ea2 to
204fdea
Compare
OmarBasem
force-pushed
the
omar/arrow-refactor
branch
from
July 15, 2026 13:29
c0bee61 to
ef1fc6f
Compare
OmarBasem
force-pushed
the
omar/loading-view
branch
from
July 15, 2026 13:29
204fdea to
7fe72f4
Compare
# Conflicts: # packages/wallet-react-ui/src/signing/pages/CollectionApproval.tsx # packages/wallet-react-ui/src/signing/pages/Erc20Approval.tsx # packages/wallet-react-ui/src/signing/pages/Erc20Transfer.tsx # packages/wallet-react-ui/src/signing/pages/EthTransfer.tsx
OmarBasem
force-pushed
the
omar/arrow-refactor
branch
from
July 15, 2026 13:39
ef1fc6f to
63521d5
Compare
commit: |
brtkx
approved these changes
Jul 15, 2026
OmarBasem
enabled auto-merge (squash)
July 15, 2026 14:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactor
ArrowCardPaircomponent toreact-uias it is reused in SRA.